Allow custom render item to wrap touchable component #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avertin
force-pushed
the
avertin/customRenderItem
branch
from
d67c8c2 to
3b21b74
Compare
avertin
force-pushed
the
avertin/customRenderItem
branch
from
3b21b74 to
8eecf96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library wraps all items that it renders in a TouchableOpacity. This is a problem if you want to use your own custom Touchable component. With the current implementation, the items are be double wrapped in Touchable components so the custom Touchable component never gets press events.
This change adds a new prop called
dontWrapItems. If this is set to true, then the library will not wrap the items in a Touchable component and instead expect the renderItem component to handle the wrapping itself. To get everything to wire up, the library will need to passdelayLongPress,onPressOut, andonPressOutto the custom Touchable via a callback inrenderItem.If the maintainer is onboard with this change, I am happy to update the readme with this info as well.
Originally written by @aarondail
Also requested by @sirajalam049 - issue #109